Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Trie and it's unit test. #13

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Added Trie and it's unit test. #13

merged 2 commits into from
Oct 2, 2018

Conversation

Zaksh
Copy link
Contributor

@Zaksh Zaksh commented Oct 1, 2018

Fixing issue #5 by adding Trie class with supoort of Insert, FindPrefix and Clear and added relevant unit test.

@Onikiro Onikiro requested a review from Rizzen October 1, 2018 21:21
Rizzen
Rizzen reviewed Oct 1, 2018
View reviewed changes
Algorithms/Algorithms.Tests/Trie/TrieTests.cs Outdated
public class TrieTests
{
[Fact]
public void Check()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split that test into few?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rizzen Done.

@Rizzen
Copy link
Member

Rizzen commented Oct 2, 2018

LGTM

@Rizzen Rizzen merged commit 9a6b6ef into Sharpach:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rizzen Rizzen Rizzen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zaksh @Rizzen